Getting Error message 'Array indices must be positive integers or logical values.'

2 views (last 30 days)
So, I have a question to do with leap Years. I have done all the code, just stuck with this error message. Here is my code
function [outputArg1] = GetLeapYears(startYear,endYear)
%UNTITLED12 Summary of this function goes here
% Detailed explanation goes here
m = (endYear - startYear)+1;
v = (startYear:1:endYear);
b = zeros(1,m);
for c = 1:m
b(c) = IsLeapYear(v(c));
end
outputArg1 = v(b);
and the IsLeapYear code is
function T = IsLeapYear(Year)
T = not (mod(Year, 4)) & (mod(Year, 100)) | not (mod(Year, 400));
end
  5 Comments
Stephen23
Stephen23 on 24 Jan 2021
Edited: Stephen23 on 24 Jan 2021
"im just wondering why it works better?"
When you preallocate the array b as numeric and then later use indexing to allocate logical values to it, the array does not change class when you allocate (via indexing) those logical values, instead those logical values are coerced into numeric values. And then because a numeric array is not a logical array you cannot use it for logical indexing (only logical arrays can be used for logical indexing). Thus Kalyan Acharjya requires the extra comparison operator on the (coerced) numeric values to see if they are equivalent to true (coerced to numeric one) which creates a logical array which is basically a copy of that numeric array... so you just end up using twice as much memory with more operations.
Note that my simpler and more efficient answer did not involve any coercion or superfluous comparison or data duplication.
James Harrison
James Harrison on 24 Jan 2021
It's a comment not an answer so im unable to accept it, however it has really helped me understand what im doing more. Thank you for your time and help!

Sign in to comment.

Accepted Answer

KALYAN ACHARJYA
KALYAN ACHARJYA on 24 Jan 2021
outputArg1 = v(b==1);
  3 Comments
Stephen23
Stephen23 on 24 Jan 2021
Edited: Stephen23 on 24 Jan 2021
Note that this does not fix the problem at it source. See my comment for the simpler solution to your actual problem.

Sign in to comment.

More Answers (0)

Tags

Community Treasure Hunt

Find the treasures in MATLAB Central and discover how the community can help you!

Start Hunting!