2 views (last 30 days)

coast=magic(14400)

di_max=100;

mx=14400;

my=14400;

for ix=1:mx

for iy=1:my

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

for dx=-di_max:di_max

for dy=-di_max:di_max

jx=ix+dx;

jy=iy+dy;

if((jx>=1) && (jx<=mx) && (jy>=1) && (jy<=my))

dd=sqrt(dx^2+dy^2);

coast(jx,jy) = min([coast(jx,jy),dd]);

end

end

end

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

end

end

Joel Handy
on 7 Aug 2019

Edited: Joel Handy
on 7 Aug 2019

The code below will do what you are asking without needing a loop.

coast=magic(14400);

di_max=100;

mx=14400;

my=14400;

[ix dx] = meshgrid(1:mx, -di_max:di_max);

[iy dy] = meshgrid(1:my, -di_max:di_max);

jx = ix+dx;

jy = iy+dy;

dd= sqrt(dx.^2+dy.^2);

mask = ((jx(:)>=1) & (jx(:)<=mx) & (jy(:)>=1) & (jy(:)<=my));

idx = sub2ind(size(coast), jx(mask), jy(mask));

coast(idx) = min(coast(idx),dd(mask));

Guillaume
on 7 Aug 2019

No idea if that produces the same result as the original code (which just fills coast with 0), but note that for the given sizes:

coast(jx(mask),jy(mask))

is about 61 TB of memory.

Joel Handy
on 7 Aug 2019

@Guillaume. I did make a bonehead mistake like I thought I might have. Fixed now hopefully.

I dont see coast filled with zeros though and I dont see how that would hapen in the original code. Cost is initialized to non-zero values and dd is rarely zero either.

Sign in to comment.

Guillaume
on 7 Aug 2019

If Joel hypothesis that "You want to look at each pixel which is mostly water, and assign a distance from the pixel to all surrounding pixels that are not water" is true (we still haven't add a proper explanation!), then as I said in a comment, this can be achieved in just one line. This is called the distance transform and is achieved in matlab with bwdist.

If all zeros pixels in coast are to be replaced by their euclidean distance to the nearest non-zero pixel, it's simply:

dist = bwdist(coast ~= 0);

coast(coast == 0) = dist(coast == 0);

Guillaume
on 7 Aug 2019

I'm not clear why you'd want a window and I don't understand how you would want it to work with a window. bwdist will find the nearest non-zero pixel however far it is, and do this very fast

Again, as I've repeatedly asked, explain in words what you're trying to achieve. e.g.: I've got a matrix coast representing _____ and a matrix water representing ____ and I want to replace the (non-zeros?zeros?something?) values by the distance to the nearest _____. If there's no nearest _______ in a window of 100x100, then I want ______.

Sign in to comment.

Sign in to answer this question.

Opportunities for recent engineering grads.

Apply Today
## 8 Comments

## Direct link to this comment

https://se.mathworks.com/matlabcentral/answers/475218-can-this-be-written-in-a-much-better-way-for-fast-computations#comment_732743

⋮## Direct link to this comment

https://se.mathworks.com/matlabcentral/answers/475218-can-this-be-written-in-a-much-better-way-for-fast-computations#comment_732743

## Direct link to this comment

https://se.mathworks.com/matlabcentral/answers/475218-can-this-be-written-in-a-much-better-way-for-fast-computations#comment_732755

⋮## Direct link to this comment

https://se.mathworks.com/matlabcentral/answers/475218-can-this-be-written-in-a-much-better-way-for-fast-computations#comment_732755

## Direct link to this comment

https://se.mathworks.com/matlabcentral/answers/475218-can-this-be-written-in-a-much-better-way-for-fast-computations#comment_732761

⋮## Direct link to this comment

https://se.mathworks.com/matlabcentral/answers/475218-can-this-be-written-in-a-much-better-way-for-fast-computations#comment_732761

## Direct link to this comment

https://se.mathworks.com/matlabcentral/answers/475218-can-this-be-written-in-a-much-better-way-for-fast-computations#comment_732771

⋮## Direct link to this comment

https://se.mathworks.com/matlabcentral/answers/475218-can-this-be-written-in-a-much-better-way-for-fast-computations#comment_732771

## Direct link to this comment

https://se.mathworks.com/matlabcentral/answers/475218-can-this-be-written-in-a-much-better-way-for-fast-computations#comment_732774

⋮## Direct link to this comment

https://se.mathworks.com/matlabcentral/answers/475218-can-this-be-written-in-a-much-better-way-for-fast-computations#comment_732774

## Direct link to this comment

https://se.mathworks.com/matlabcentral/answers/475218-can-this-be-written-in-a-much-better-way-for-fast-computations#comment_732782

⋮## Direct link to this comment

https://se.mathworks.com/matlabcentral/answers/475218-can-this-be-written-in-a-much-better-way-for-fast-computations#comment_732782

## Direct link to this comment

https://se.mathworks.com/matlabcentral/answers/475218-can-this-be-written-in-a-much-better-way-for-fast-computations#comment_732783

⋮## Direct link to this comment

https://se.mathworks.com/matlabcentral/answers/475218-can-this-be-written-in-a-much-better-way-for-fast-computations#comment_732783

## Direct link to this comment

https://se.mathworks.com/matlabcentral/answers/475218-can-this-be-written-in-a-much-better-way-for-fast-computations#comment_732797

⋮## Direct link to this comment

https://se.mathworks.com/matlabcentral/answers/475218-can-this-be-written-in-a-much-better-way-for-fast-computations#comment_732797

Sign in to comment.