Why does my vector repeat numbers?

So I am trying to sort a random array of integers and with my code everything works except certain numbers will repeat multiple times. I'm not sure what I am doing that's making it repeat but I think it has to do with me possibly overwriting my variable x(k).
function y = sort(x)
for k = 1:length(x)-1
% Compare x(k) with values in original array x
for i = (k+1):length(x)
if x(k) < x(i)
temp = 0;
temp = x(i);
x(k) = temp;
end
end
y = x;

4 Comments

Whoa, careful writing a function called sort. That's already the name of a built-in function! This will make it hard to be confident that Matlab is choosing to use the version of sort that you want Matlab to use. If you use someone else's code or download File Exchange submissions that use the built-in sort, Matlab might try to use your sort instead. Rename your sort to mysort or something meaningful.
Thanks for looking out when I copy pasted my code I realized I didn't get my function line so I just named it something generic for my post hence "sort".
Also note that you should avoid using i and j as variable names, as these are both names of the inbuilt imaginary unit.
Also be careful using i and j as variables. They're both built in as the imaginary unit. Overwriting them is usually not a problem, but when it is a problem, it can be hard to track down.

Sign in to comment.

 Accepted Answer

KL
KL on 28 Apr 2015
Edited: KL on 28 Apr 2015
for j = 1:length(x)-1
% Find jth smallest element
imin = j;
for i = (j + 1):length(x)
if (x(i) < x(imin))
imin = i;
end
end
if (imin ~= j)
val = x(imin);
x(imin) = x(j);
x(j) = val;
end
end

1 Comment

Works perfectly had to change the logical expression so the array would descend rather than ascend. Thanks a bunch.

Sign in to comment.

More Answers (0)

Categories

Products

Tags

Asked:

on 28 Apr 2015

Commented:

on 28 Apr 2015

Community Treasure Hunt

Find the treasures in MATLAB Central and discover how the community can help you!

Start Hunting!